Docker support #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filiprogrammer
requested changes
Nov 6, 2024
petre-c
force-pushed
the
docker
branch
2 times, most recently
from
bfc4e3b to
3edad14
Compare
Filiprogrammer
requested changes
Nov 10, 2024
Owner
Filiprogrammer
left a comment
Filiprogrammer
left a comment
There was a problem hiding this comment.
Thanks for the contributions so far!
I played around a bit with the Docker image and I still have some suggestions.
Added docker compose option in README.md
- Modified Dockerfile to execute the script with only ENTRYPOINT (removed CMD) for passing arguments from docker run / docker compose - docker-compose.yml - Passed `--no-tls` argument to command; - Set 18080 as the host port for `--no-tls` (4443 used regardless of tls/no-tls in the container).
Co-authored-by: Filiprogrammer <44641787+Filiprogrammer@users.noreply.github.com>
Co-authored-by: Filiprogrammer <44641787+Filiprogrammer@users.noreply.github.com>
Substituted '-' for '_' in docker-compose.yml
Contributor
Author
|
I appreciate your level of attention to detail! |
Filiprogrammer
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Filiprogrammer, please note - #4 issue stands on debian as well as on docker