Add OpenBSD support#110
Closed
jturner wants to merge 2 commits intoFiloSottile:masterfrom
jturner:openbsd-support
Closed
Add OpenBSD support#110jturner wants to merge 2 commits intoFiloSottile:masterfrom jturner:openbsd-support
jturner wants to merge 2 commits intoFiloSottile:masterfrom
jturner:openbsd-support
Conversation
FiloSottile
requested changes
Feb 2, 2019
Owner
FiloSottile
left a comment
FiloSottile
left a comment
There was a problem hiding this comment.
I'd like to support the system root store before merging this, as otherwise it will keep displaying warnings.
Also, truststore_openbsd.go is almost the same as truststore_linux.go. I wonder if we could merge them into a single truststore_unix.go with a build tag and a couple ifs.
| hasCertutil = err == nil | ||
|
|
||
| case "linux": | ||
| case "openbsd": |
Owner
There was a problem hiding this comment.
This breaks Linux, there's no fallthrough in Go switch statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for OpenBSD. No global system store so just adds to firefox/chromium.