linux: support chrome via nss/certutil#15
Closed
adamdecaf wants to merge 1 commit intoFiloSottile:masterfrom
Closed
linux: support chrome via nss/certutil#15adamdecaf wants to merge 1 commit intoFiloSottile:masterfrom
adamdecaf wants to merge 1 commit intoFiloSottile:masterfrom
Conversation
552653e to
d5cf2a7
Compare
Contributor
|
Isn't "brew", "--prefix", "nss" failing on your system, so you get diff --git a/truststore_firefox.go b/truststore_firefox.go
index 2410f21..611791f 100644
--- a/truststore_firefox.go
+++ b/truststore_firefox.go
@@ -18,6 +18,12 @@ func init() {
_, err := os.Stat(FirefoxPath)
hasFirefox = !os.IsNotExist(err)
+ certutilPath, err = exec.LookPath("certutil")
+ if err == nil {
+ hasCertutil = true
+ return
+ }
+
out, err := exec.Command("brew", "--prefix", "nss").Output()
if err != nil {
returnbut even that fails, for some reason I have not checked: mkcert$ ./mkcert -install
Using the local CA at "/home/chlunde/.local/share/mkcert" ✨
ERROR: failed to execute "certutil -A": exit status 255
certutil: function failed: SEC_ERROR_LEGACY_DATABASE: The certificate/key database is in an old, unsupported format.
|
Contributor
Author
|
My bad. I've got a fix incoming. |
d5cf2a7 to
8f8318a
Compare
Contributor
Author
|
This worked for me locally, but I also created #18 to drop the Test runsEdit: rebased after that PR was merged. |
8f8318a to
21621ac
Compare
Owner
Owner
|
Thanks @adamdecaf, I used some of your code, but went for something a bit more DRY even if not as precise. Review and testing very welcome! |
Contributor
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #11