README: use $GOBIN instead of $GOPATH/bin#168
Merged
FiloSottile merged 1 commit intoFiloSottile:masterfrom Jun 12, 2019
mvdan:master
Merged
README: use $GOBIN instead of $GOPATH/bin#168FiloSottile merged 1 commit intoFiloSottile:masterfrom mvdan:master
FiloSottile merged 1 commit intoFiloSottile:masterfrom
mvdan:master
Conversation
$GOPATH/bin works in the simple cases, but will break if the user specifies their own $GOBIN, or if their $GOPATH has multiple elements. This form is also simpler. Even if the user doesn't specify their custom $GOBIN, 'go env GOBIN' will return the correct default.
Owner
|
Thanks! |
@mvdan I can't reproduce this. Any ideas what's different about your setup such that you can? go env Output |
Contributor
Author
|
You're right, I think the only properly correct way is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$GOPATH/bin works in the simple cases, but will break if the user
specifies their own $GOBIN, or if their $GOPATH has multiple elements.
This form is also simpler. Even if the user doesn't specify their custom
$GOBIN, 'go env GOBIN' will return the correct default.