Skip to content

on linux don't declare we installed to the system store #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FiloSottile merged 1 commit into from
Jun 29, 2018
Merged

on linux don't declare we installed to the system store #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,13 @@ func (m *mkcert) install() {
var printed bool
if !m.checkPlatform() {
m.installPlatform()
m.ignoreCheckFailure = true // TODO: replace with a check for a successful install
log.Print("The local CA is now installed in the system trust store! ⚡️")

// TODO: replace with a check for a successful install, drop OS check
m.ignoreCheckFailure = true
if runtime.GOOS != "linux" {
log.Print("The local CA is now installed in the system trust store! ⚡️")
}

printed = true
}
if hasFirefox && !m.checkFirefox() {
Expand Down
3 changes: 2 additions & 1 deletion truststore_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ var (
)

func (m *mkcert) installPlatform() {
log.Fatalf("-install is not yet supported on Linux 😣\nYou can manually install the root certificate at %q in the meantime.", filepath.Join(m.CAROOT, rootName))
log.Println(" -install is not yet fully supported on Linux 😣")
log.Printf("You can manually install the root certificate at %q in the meantime.", filepath.Join(m.CAROOT, rootName))
}

func (m *mkcert) uninstallPlatform() {}