Use regexp compile#211
Closed
CallanTaylor wants to merge 3 commits intoFiloSottile:masterfrom
CallanTaylor:use-regexp-compile
Closed
Use regexp compile#211CallanTaylor wants to merge 3 commits intoFiloSottile:masterfrom CallanTaylor:use-regexp-compile
CallanTaylor wants to merge 3 commits intoFiloSottile:masterfrom
CallanTaylor:use-regexp-compile
Conversation
Owner
|
Thank you, but this is a static well-tested regex, I am comfortable with the simpler thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regexp.MustCompile function panics if the regex fails to compile and should only be used in globals or init functions. Instead use regexp.Compile and check
erris nil.