truststore: check if profile is a directory before joining cert*.db#33
Merged
FiloSottile merged 2 commits intoFiloSottile:masterfrom Jul 4, 2018
ansemjo:master
Merged
truststore: check if profile is a directory before joining cert*.db#33FiloSottile merged 2 commits intoFiloSottile:masterfrom ansemjo:master
FiloSottile merged 2 commits intoFiloSottile:masterfrom
ansemjo:master
Conversation
Owner
|
@ansemjo Hi! Sorry for not bringing this up properly earlier. Contributions to this code are covered by the Google CLA, could you please read it (it's pretty quick) and let me know when you sign it? Thank you! https://github.com/FiloSottile/mkcert/blob/master/CONTRIBUTING.md#contributor-license-agreement |
Contributor
Author
|
Sure. I thought I had signed a CLA in the past but apparently Google had none on file .. Signed just now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #12, because the
FirefoxProfileglob also matches files likeprofile.ini.