Inform the user about the p12 password#87
Conversation
Also make it less silly
ghost
mentioned this pull request
adamdecaf
reviewed
Oct 30, 2018
| } else { | ||
| domainCert, _ := x509.ParseCertificate(cert) | ||
| pfxData, err := pkcs12.Encode(rand.Reader, priv, domainCert, []*x509.Certificate{m.caCert}, "changeit") | ||
| pfxData, err := pkcs12.Encode(rand.Reader, priv, domainCert, []*x509.Certificate{m.caCert}, "123456") |
Contributor
There was a problem hiding this comment.
I don't think we can change the password as there are already lots of installs using changeit.
Author
|
Sorry for the mess, I think it's all good now. |
Contributor
|
Thanks 👍 Could you squash the commits? |
Author
|
Sorry I don't know how to do that. |
Owner
|
Thanks for the PR, I made a similar change in 6060e20. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also make it less silly