CircleCI test to validate from-bodyxml #60
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need a way to validate that our migration library (
from-bodyxml) works for all of FT pink's contentProposed solution
A test in CircleCI that:
from-bodyxmlon themExample: https://app.circleci.com/pipelines/github/Financial-Times/content-tree/453/workflows/98438d49-c044-48d6-98c7-6ae43fcc3593/jobs/445/steps
Limitations
layoutWidth, this test would pass). A possible improvement here is to also compare the output against what is being created by cp-content-pipeline-api (assuming that is a reasonable source-of-truth for correctness, given it currently serves the website).Despite the limitations, hopefully this is still useful at least for an indication of how close to complete the migration code is.