Skip to content

Add ability to control dismiss behavior after copy message#111

Closed
RoadToDream wants to merge 5 commits intoFinb:masterfrom
RoadToDream:master
Closed

Add ability to control dismiss behavior after copy message#111
RoadToDream wants to merge 5 commits intoFinb:masterfrom
RoadToDream:master

Conversation

@RoadToDream
Copy link
Copy Markdown
Contributor

@RoadToDream RoadToDream commented Sep 3, 2021

This commit add ability to control dismiss behavior after copy message.

Hi Finb,
Thank you for bringing this app to us, which greatly helps my entire workflow, thank you.
Not sure if this patch matches your vision towards Bark, but at least it provides additional control to users.

Best

@RoadToDream RoadToDream changed the title Add ability to control dismiss behavior notification after copy message Add ability to control dismiss behavior after copy message Sep 4, 2021
@Finb
Copy link
Copy Markdown
Owner

Finb commented Sep 5, 2021

I think instead of adding it as a default option, you can add it as a url request parameter.

This feature is very underused, don't even set up a tutorial card for it, just tell someone when they need it.

@RoadToDream
Copy link
Copy Markdown
Contributor Author

I think instead of adding it as a default option, you can add it as a url request parameter.

This feature is very underused, don't even set up a tutorial card for it, just tell someone when they need it.

Oh I didn't know it can be achieved by sending a url request parameter, that would be great! May I ask how to set up?

My initial thought is that after copy the content from pulling down the notification, most user will turn to another app to paste and tend not to stay in the notification, so click outside to dismiss the notification feels a little non-intuitive.

@Finb
Copy link
Copy Markdown
Owner

Finb commented Sep 6, 2021

All url parameters can be taken like this. (All parameter names will be converted to lowercase)

if let archive = userInfo["isarchive"] as? String{

@RoadToDream
Copy link
Copy Markdown
Contributor Author

I get it, thank you!
It seems that I did not explain purpose of this commit clearly...
I intended to provide control that the notification will diss or not,
so mainly about
completion(.doNotDismiss)
L66 in NotificationViewController.swift
isArchive seems to control whether the message will be stored in message history

But overall its a very personal request, so I will give all respects on your decision : )
Love the app and thank you for all the contribution.

@RoadToDream RoadToDream closed this by deleting the head repository Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants