chore(README): add guide on building docker image#23
Closed
birkhofflee wants to merge 1 commit intoFinb:masterfrom
Closed
chore(README): add guide on building docker image#23birkhofflee wants to merge 1 commit intoFinb:masterfrom
birkhofflee wants to merge 1 commit intoFinb:masterfrom
Conversation
Collaborator
|
The project provides Makefile files for executing make commands to compile binary files, docker images, etc.; For users, there is no need to care about how to build docker image, we have provided pre-build docker image in docker hub( |
Author
|
Oh. I did not see there was a Makefile. Then this commit is no longer a need :) |
Collaborator
👌 |
Owner
|
@E021ntox |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be confusing that Dockerfile is actually put in a subdirectory in the project. We need to build in project root in order for Docker build daemon to access the version file.