Closed
Conversation
qcgzxw
commented
Dec 25, 2024
- 参数获取方式重构,更简洁
- api v2暂未实现 device_keys的,兼容device_key 使用逗号分隔多个key
- 抽离pusher接口,后续兼容多平台推送
Author
|
想要实现其他平台的推送,抽离Pusher接口 |
Owner
|
哈喽,感谢PR,但有一些问题。 Bark 的参数因为用户的调用环境很多,所以支持在 url 路径、Query Parameters、请求体 body 中传递参数。其中 body 支持key-value 或 json 格式。 不管是GET POST 都会去这些位置取值。 我发现这个PR改动会导致很多之前能正常请求的参数传递方式,会变的不可用,但一般需要对这些参数传递方式进行兼容(因为无法通知到用户更新到新的传递方式,也不能突然让用户不能推送) 例如这个pr 忽略了body中的参数,除非使用了 /push 。 另外考虑到稳定性,bark-server也不想对代码进行大改,所以暂时关闭这个pr,感谢! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.