Add support for mysql instead of Bbolt and URL prefix strip#82
Merged
Finb merged 5 commits intoFinb:masterfrom Sep 22, 2021
athurg:support_mysql
Merged
Add support for mysql instead of Bbolt and URL prefix strip#82Finb merged 5 commits intoFinb:masterfrom athurg:support_mysql
Finb merged 5 commits intoFinb:masterfrom
athurg:support_mysql
Conversation
Owner
|
Thanks for the PR 👍, support for mysql looks good, but the "URL prefix strip " seems unnecessary. Several problems were found after testing.
|
Author
|
It seems the URL prefix is works fine. But the Register:Test with {"code":200,"message":"success","data":{"device_token":"mytoken2","key":"K4CQk9egRfuwkDhNFsEH3R","device_key":"K4CQk9egRfuwkDhNFsEH3R"},"timestamp":1632101378}UpdateTest with {"code":200,"message":"success","data":{"device_key":"yvCGehiTKpXmyZHTHaoZcR","device_token":"mytoken2222,device_key=K4CQk9egRfuwkDhNFsEH3R","key":"yvCGehiTKpXmyZHTHaoZcR"},"timestamp":1632101764}Push:Test with {"code":500,"message":"push failed: APNS push failed: BadDeviceToken","timestamp":1632101352}PS: It's OK because the test device token is invalid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support MySQL instead of Bbolt
Add support for mysql instead of Bbolt.
So we can run it without local file system requirement.
It's convenient to use in the container environment , especially in clusters like kubernetes.
Support URL Path Prefix strip
While most of LoadBalancer does not support strip URL path prefix. This URL path prefix was used when multiple application shared a load balancer.
For example, bark-server and gmail share a LB bind with api.google.com. They can both access by
http://api.google.com/bark-server/pingandhttp://api.google.com/gmail/ping. When the LB forward the request to bark-server, it will send a request PATH/bark-server/ping, not a really PATH/pingwith the prefix/bark-serverstripped.So we should strip it by self, and this feature do this.