Search controller scaffolding#255
Merged
R-Sandor merged 2 commits intoFindFirst-Development:mainfrom Oct 17, 2024
Merged
Conversation
1 task
R-Sandor
approved these changes
Oct 17, 2024
Collaborator
There was a problem hiding this comment.
Looks good!
We probably could have used the class level @RequestMapping like we do in ImageController.java:
https://github.com/R-Sandor/FindFirst/blob/6eeb31351850568c884f28225676dfdb542a4704/server/src/main/java/dev/findfirst/core/controller/ImageController.java#L16
but I wasn't consistent with that in the BookmarkController.java, where every path has the full path.
The RequestMapping on the class prefixes all mapping with the class level path.
I am only mentioning it here as a nice to know if you see that in the code that's what the class level Mapping is doing.
Very nice PR again! Thank you! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #250
Checklist