Skip to content

Search controller scaffolding#255

Merged
R-Sandor merged 2 commits intoFindFirst-Development:mainfrom
joelramilison:search-controller-scaffolding
Oct 17, 2024
Merged

Search controller scaffolding#255
R-Sandor merged 2 commits intoFindFirst-Development:mainfrom
joelramilison:search-controller-scaffolding

Conversation

@joelramilison
Copy link
Contributor

Issue number: resolves #250


Checklist

  • Code Formatter (run prettier/spotlessApply)
  • Code has unit tests? (If no explain in other_information)
  • Builds on localhost
  • Builds/Runs in docker compose (INFO: haven't tried)

Copy link
Collaborator

@R-Sandor R-Sandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

We probably could have used the class level @RequestMapping like we do in ImageController.java:
https://github.com/R-Sandor/FindFirst/blob/6eeb31351850568c884f28225676dfdb542a4704/server/src/main/java/dev/findfirst/core/controller/ImageController.java#L16

but I wasn't consistent with that in the BookmarkController.java, where every path has the full path.

The RequestMapping on the class prefixes all mapping with the class level path.
I am only mentioning it here as a nice to know if you see that in the code that's what the class level Mapping is doing.

Very nice PR again! Thank you! 🚀

@R-Sandor R-Sandor merged commit 1c08b8b into FindFirst-Development:main Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Server] Create SearchController.java

2 participants