keygeneratortestfileadded#331
Merged
R-Sandor merged 1 commit intoFindFirst-Development:mainfrom Feb 11, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #329
Summary:
Added comprehensive unit tests for the KeyGenerator class to improve code coverage and verify key generation functionality.
Changes Made:
Valid Key Generation:
Created tests to verify that keys generated by KeyGenerator.generateKeys are correctly formatted in PEM format. The tests check for the presence of proper header and footer lines (e.g., "-----BEGIN PUBLIC KEY-----") and validate that the Base64-decoded key data is not empty.
No Overwriting of Existing Keys:
Added a test to ensure that if key files already exist (simulated using dummy data), calling generateKeys does not overwrite the existing files.
Unique Keys on Separate Runs:
Implemented tests that generate keys using separate file paths to confirm that each run produces a unique key pair.
Impact:
These changes resolve the issue by increasing code coverage for the key generator and ensuring its behavior is correct under different scenarios.