AOS-654 Template 값들을 V2 기준에 맞게 변경 #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdohun0104
requested changes
Aug 4, 2021
| override fun setBindingVariables() { | ||
| binding.viewModel = viewModel | ||
| } | ||
| override val viewModel: $NAME$ViewModel by sharedViewModel() |
Contributor
There was a problem hiding this comment.
이 부분같은 경우엔 sharedViewModel를 사용하지 않는 케이스일 경우가 더 많을 것 같아서,
그냥 비워둔채로 나두어도 괜찮을 것 같습니다.
템플릿으론 생성만 해주고, 이런 부분은 상세 구현쪽이라고 생각하는 것이 좋을 것 같습니다.
Activity같은 경우는 거의 고정이라 잘 모르겠지만, fragment는 비우는 것이 더 좋을 것 같습니다.
Member
Author
There was a problem hiding this comment.
근데 Fragment으로 설정하고 생성하면 일단 ViewModel도 같이 생성하는 거 아닌가요
일단 기본적으로 템플릿인데 ViewModel 파일은 생성되고, sharedViewModel() 과 import 문 등을 직접 추가해야 되는 경우는 오히려 발생하면 안된다고 생각합니다. 차라리 지우는 형태로 가는 것이 맞다고 봐요.
Contributor
There was a problem hiding this comment.
그러네요 그럼 유지하는 것으로 approve 하겠습니다
kimdohun0104
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template 값들을 V2 기준에 맞게 변경 했습니다.
layoutTemplate 는 빌드시 문제되는 내용 제거했습니다.