Skip to content

feat(be-tier8): BE support for Rgb48/Bgr48/Rgba64/Bgra64/X2Rgb10/X2Bgr10 row kernels #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uqio wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(be-tier8): BE support for Rgb48/Bgr48/Rgba64/Bgra64/X2Rgb10/X2Bgr10 row kernels #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ed30cd
feat(be-tier8): BE support for Rgb48/Bgr48/Rgba64/Bgra64/X2Rgb10/X2Bg…
uqio May 7, 2026
e02e078
fix(be-tier8): make scalar BE conversion target-endian aware
uqio May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
462 changes: 249 additions & 213 deletions src/row/arch/neon/packed_rgb.rs
View file
Open in desktop

Large diffs are not rendered by default.

276 changes: 207 additions & 69 deletions src/row/arch/neon/packed_rgb_16bit.rs
View file
Open in desktop

Large diffs are not rendered by default.

24 changes: 12 additions & 12 deletions src/row/arch/neon/tests/packed_rgb.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,9 @@ fn x2rgb10_to_rgb_neon_matches_scalar_widths() {
let input = pseudo_random_rgba(w);
let mut out_scalar = std::vec![0u8; w * 3];
let mut out_neon = std::vec![0u8; w * 3];
scalar::x2rgb10_to_rgb_row(&input, &mut out_scalar, w);
scalar::x2rgb10_to_rgb_row::<false>(&input, &mut out_scalar, w);
unsafe {
x2rgb10_to_rgb_row(&input, &mut out_neon, w);
x2rgb10_to_rgb_row::<false>(&input, &mut out_neon, w);
}
assert_eq!(out_scalar, out_neon, "width {w}");
}
Expand All @@ -276,9 +276,9 @@ fn x2rgb10_to_rgba_neon_matches_scalar_widths() {
let input = pseudo_random_rgba(w);
let mut out_scalar = std::vec![0u8; w * 4];
let mut out_neon = std::vec![0u8; w * 4];
scalar::x2rgb10_to_rgba_row(&input, &mut out_scalar, w);
scalar::x2rgb10_to_rgba_row::<false>(&input, &mut out_scalar, w);
unsafe {
x2rgb10_to_rgba_row(&input, &mut out_neon, w);
x2rgb10_to_rgba_row::<false>(&input, &mut out_neon, w);
}
assert_eq!(out_scalar, out_neon, "width {w}");
}
Expand All @@ -291,9 +291,9 @@ fn x2rgb10_to_rgb_u16_neon_matches_scalar_widths() {
let input = pseudo_random_rgba(w);
let mut out_scalar = std::vec![0u16; w * 3];
let mut out_neon = std::vec![0u16; w * 3];
scalar::x2rgb10_to_rgb_u16_row(&input, &mut out_scalar, w);
scalar::x2rgb10_to_rgb_u16_row::<false>(&input, &mut out_scalar, w);
unsafe {
x2rgb10_to_rgb_u16_row(&input, &mut out_neon, w);
x2rgb10_to_rgb_u16_row::<false>(&input, &mut out_neon, w);
}
assert_eq!(out_scalar, out_neon, "width {w}");
}
Expand All @@ -306,9 +306,9 @@ fn x2bgr10_to_rgb_neon_matches_scalar_widths() {
let input = pseudo_random_rgba(w);
let mut out_scalar = std::vec![0u8; w * 3];
let mut out_neon = std::vec![0u8; w * 3];
scalar::x2bgr10_to_rgb_row(&input, &mut out_scalar, w);
scalar::x2bgr10_to_rgb_row::<false>(&input, &mut out_scalar, w);
unsafe {
x2bgr10_to_rgb_row(&input, &mut out_neon, w);
x2bgr10_to_rgb_row::<false>(&input, &mut out_neon, w);
}
assert_eq!(out_scalar, out_neon, "width {w}");
}
Expand All @@ -321,9 +321,9 @@ fn x2bgr10_to_rgba_neon_matches_scalar_widths() {
let input = pseudo_random_rgba(w);
let mut out_scalar = std::vec![0u8; w * 4];
let mut out_neon = std::vec![0u8; w * 4];
scalar::x2bgr10_to_rgba_row(&input, &mut out_scalar, w);
scalar::x2bgr10_to_rgba_row::<false>(&input, &mut out_scalar, w);
unsafe {
x2bgr10_to_rgba_row(&input, &mut out_neon, w);
x2bgr10_to_rgba_row::<false>(&input, &mut out_neon, w);
}
assert_eq!(out_scalar, out_neon, "width {w}");
}
Expand All @@ -336,9 +336,9 @@ fn x2bgr10_to_rgb_u16_neon_matches_scalar_widths() {
let input = pseudo_random_rgba(w);
let mut out_scalar = std::vec![0u16; w * 3];
let mut out_neon = std::vec![0u16; w * 3];
scalar::x2bgr10_to_rgb_u16_row(&input, &mut out_scalar, w);
scalar::x2bgr10_to_rgb_u16_row::<false>(&input, &mut out_scalar, w);
unsafe {
x2bgr10_to_rgb_u16_row(&input, &mut out_neon, w);
x2bgr10_to_rgb_u16_row::<false>(&input, &mut out_neon, w);
}
assert_eq!(out_scalar, out_neon, "width {w}");
}
Expand Down
80 changes: 40 additions & 40 deletions src/row/arch/neon/tests/packed_rgb_16bit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ fn neon_rgb48_to_rgb_matches_scalar_width17() {
let src = make_rgb48_src(17, 0x0101);
let mut simd_out = std::vec![0u8; 17 * 3];
let mut scalar_out = std::vec![0u8; 17 * 3];
unsafe { neon_rgb48_to_rgb_row(&src, &mut simd_out, 17) };
scalar::rgb48_to_rgb_row(&src, &mut scalar_out, 17);
unsafe { neon_rgb48_to_rgb_row::<false>(&src, &mut simd_out, 17) };
scalar::rgb48_to_rgb_row::<false>(&src, &mut scalar_out, 17);
assert_eq!(simd_out, scalar_out, "rgb48→rgb: SIMD vs scalar mismatch");
}

Expand All @@ -45,8 +45,8 @@ fn neon_rgb48_to_rgba_matches_scalar_width17() {
let src = make_rgb48_src(17, 0x0303);
let mut simd_out = std::vec![0u8; 17 * 4];
let mut scalar_out = std::vec![0u8; 17 * 4];
unsafe { neon_rgb48_to_rgba_row(&src, &mut simd_out, 17) };
scalar::rgb48_to_rgba_row(&src, &mut scalar_out, 17);
unsafe { neon_rgb48_to_rgba_row::<false>(&src, &mut simd_out, 17) };
scalar::rgb48_to_rgba_row::<false>(&src, &mut scalar_out, 17);
assert_eq!(simd_out, scalar_out, "rgb48→rgba: SIMD vs scalar mismatch");
}

Expand All @@ -57,8 +57,8 @@ fn neon_rgb48_to_rgb_u16_matches_scalar_width17() {
let src = make_rgb48_src(17, 0x0505);
let mut simd_out = std::vec![0u16; 17 * 3];
let mut scalar_out = std::vec![0u16; 17 * 3];
unsafe { neon_rgb48_to_rgb_u16_row(&src, &mut simd_out, 17) };
scalar::rgb48_to_rgb_u16_row(&src, &mut scalar_out, 17);
unsafe { neon_rgb48_to_rgb_u16_row::<false>(&src, &mut simd_out, 17) };
scalar::rgb48_to_rgb_u16_row::<false>(&src, &mut scalar_out, 17);
assert_eq!(
simd_out, scalar_out,
"rgb48→rgb_u16: SIMD vs scalar mismatch"
Expand All @@ -72,8 +72,8 @@ fn neon_rgb48_to_rgba_u16_matches_scalar_width17() {
let src = make_rgb48_src(17, 0x0707);
let mut simd_out = std::vec![0u16; 17 * 4];
let mut scalar_out = std::vec![0u16; 17 * 4];
unsafe { neon_rgb48_to_rgba_u16_row(&src, &mut simd_out, 17) };
scalar::rgb48_to_rgba_u16_row(&src, &mut scalar_out, 17);
unsafe { neon_rgb48_to_rgba_u16_row::<false>(&src, &mut simd_out, 17) };
scalar::rgb48_to_rgba_u16_row::<false>(&src, &mut scalar_out, 17);
assert_eq!(
simd_out, scalar_out,
"rgb48→rgba_u16: SIMD vs scalar mismatch"
Expand All @@ -91,8 +91,8 @@ fn neon_bgr48_to_rgb_matches_scalar_width17() {
let src = make_rgb48_src(17, 0x1111);
let mut simd_out = std::vec![0u8; 17 * 3];
let mut scalar_out = std::vec![0u8; 17 * 3];
unsafe { neon_bgr48_to_rgb_row(&src, &mut simd_out, 17) };
scalar::bgr48_to_rgb_row(&src, &mut scalar_out, 17);
unsafe { neon_bgr48_to_rgb_row::<false>(&src, &mut simd_out, 17) };
scalar::bgr48_to_rgb_row::<false>(&src, &mut scalar_out, 17);
assert_eq!(simd_out, scalar_out, "bgr48→rgb: SIMD vs scalar mismatch");
}

Expand All @@ -103,8 +103,8 @@ fn neon_bgr48_to_rgba_matches_scalar_width17() {
let src = make_rgb48_src(17, 0x2222);
let mut simd_out = std::vec![0u8; 17 * 4];
let mut scalar_out = std::vec![0u8; 17 * 4];
unsafe { neon_bgr48_to_rgba_row(&src, &mut simd_out, 17) };
scalar::bgr48_to_rgba_row(&src, &mut scalar_out, 17);
unsafe { neon_bgr48_to_rgba_row::<false>(&src, &mut simd_out, 17) };
scalar::bgr48_to_rgba_row::<false>(&src, &mut scalar_out, 17);
assert_eq!(simd_out, scalar_out, "bgr48→rgba: SIMD vs scalar mismatch");
}

Expand All @@ -115,8 +115,8 @@ fn neon_bgr48_to_rgb_u16_matches_scalar_width17() {
let src = make_rgb48_src(17, 0x3333);
let mut simd_out = std::vec![0u16; 17 * 3];
let mut scalar_out = std::vec![0u16; 17 * 3];
unsafe { neon_bgr48_to_rgb_u16_row(&src, &mut simd_out, 17) };
scalar::bgr48_to_rgb_u16_row(&src, &mut scalar_out, 17);
unsafe { neon_bgr48_to_rgb_u16_row::<false>(&src, &mut simd_out, 17) };
scalar::bgr48_to_rgb_u16_row::<false>(&src, &mut scalar_out, 17);
assert_eq!(
simd_out, scalar_out,
"bgr48→rgb_u16: SIMD vs scalar mismatch"
Expand All @@ -130,8 +130,8 @@ fn neon_bgr48_to_rgba_u16_matches_scalar_width17() {
let src = make_rgb48_src(17, 0x4444);
let mut simd_out = std::vec![0u16; 17 * 4];
let mut scalar_out = std::vec![0u16; 17 * 4];
unsafe { neon_bgr48_to_rgba_u16_row(&src, &mut simd_out, 17) };
scalar::bgr48_to_rgba_u16_row(&src, &mut scalar_out, 17);
unsafe { neon_bgr48_to_rgba_u16_row::<false>(&src, &mut simd_out, 17) };
scalar::bgr48_to_rgba_u16_row::<false>(&src, &mut scalar_out, 17);
assert_eq!(
simd_out, scalar_out,
"bgr48→rgba_u16: SIMD vs scalar mismatch"
Expand All @@ -149,8 +149,8 @@ fn neon_rgba64_to_rgb_matches_scalar_width17() {
let src = make_rgba64_src(17, 0xAAAA);
let mut simd_out = std::vec![0u8; 17 * 3];
let mut scalar_out = std::vec![0u8; 17 * 3];
unsafe { neon_rgba64_to_rgb_row(&src, &mut simd_out, 17) };
scalar::rgba64_to_rgb_row(&src, &mut scalar_out, 17);
unsafe { neon_rgba64_to_rgb_row::<false>(&src, &mut simd_out, 17) };
scalar::rgba64_to_rgb_row::<false>(&src, &mut scalar_out, 17);
assert_eq!(simd_out, scalar_out, "rgba64→rgb: SIMD vs scalar mismatch");
}

Expand All @@ -161,8 +161,8 @@ fn neon_rgba64_to_rgba_matches_scalar_width17() {
let src = make_rgba64_src(17, 0xBBBB);
let mut simd_out = std::vec![0u8; 17 * 4];
let mut scalar_out = std::vec![0u8; 17 * 4];
unsafe { neon_rgba64_to_rgba_row(&src, &mut simd_out, 17) };
scalar::rgba64_to_rgba_row(&src, &mut scalar_out, 17);
unsafe { neon_rgba64_to_rgba_row::<false>(&src, &mut simd_out, 17) };
scalar::rgba64_to_rgba_row::<false>(&src, &mut scalar_out, 17);
assert_eq!(simd_out, scalar_out, "rgba64→rgba: SIMD vs scalar mismatch");
}

Expand All @@ -173,8 +173,8 @@ fn neon_rgba64_to_rgb_u16_matches_scalar_width17() {
let src = make_rgba64_src(17, 0xCCCC);
let mut simd_out = std::vec![0u16; 17 * 3];
let mut scalar_out = std::vec![0u16; 17 * 3];
unsafe { neon_rgba64_to_rgb_u16_row(&src, &mut simd_out, 17) };
scalar::rgba64_to_rgb_u16_row(&src, &mut scalar_out, 17);
unsafe { neon_rgba64_to_rgb_u16_row::<false>(&src, &mut simd_out, 17) };
scalar::rgba64_to_rgb_u16_row::<false>(&src, &mut scalar_out, 17);
assert_eq!(
simd_out, scalar_out,
"rgba64→rgb_u16: SIMD vs scalar mismatch"
Expand All @@ -188,8 +188,8 @@ fn neon_rgba64_to_rgba_u16_matches_scalar_width17() {
let src = make_rgba64_src(17, 0xDDDD);
let mut simd_out = std::vec![0u16; 17 * 4];
let mut scalar_out = std::vec![0u16; 17 * 4];
unsafe { neon_rgba64_to_rgba_u16_row(&src, &mut simd_out, 17) };
scalar::rgba64_to_rgba_u16_row(&src, &mut scalar_out, 17);
unsafe { neon_rgba64_to_rgba_u16_row::<false>(&src, &mut simd_out, 17) };
scalar::rgba64_to_rgba_u16_row::<false>(&src, &mut scalar_out, 17);
assert_eq!(
simd_out, scalar_out,
"rgba64→rgba_u16: SIMD vs scalar mismatch"
Expand All @@ -207,8 +207,8 @@ fn neon_bgra64_to_rgb_matches_scalar_width17() {
let src = make_rgba64_src(17, 0x1234);
let mut simd_out = std::vec![0u8; 17 * 3];
let mut scalar_out = std::vec![0u8; 17 * 3];
unsafe { neon_bgra64_to_rgb_row(&src, &mut simd_out, 17) };
scalar::bgra64_to_rgb_row(&src, &mut scalar_out, 17);
unsafe { neon_bgra64_to_rgb_row::<false>(&src, &mut simd_out, 17) };
scalar::bgra64_to_rgb_row::<false>(&src, &mut scalar_out, 17);
assert_eq!(simd_out, scalar_out, "bgra64→rgb: SIMD vs scalar mismatch");
}

Expand All @@ -219,8 +219,8 @@ fn neon_bgra64_to_rgba_matches_scalar_width17() {
let src = make_rgba64_src(17, 0x5678);
let mut simd_out = std::vec![0u8; 17 * 4];
let mut scalar_out = std::vec![0u8; 17 * 4];
unsafe { neon_bgra64_to_rgba_row(&src, &mut simd_out, 17) };
scalar::bgra64_to_rgba_row(&src, &mut scalar_out, 17);
unsafe { neon_bgra64_to_rgba_row::<false>(&src, &mut simd_out, 17) };
scalar::bgra64_to_rgba_row::<false>(&src, &mut scalar_out, 17);
assert_eq!(simd_out, scalar_out, "bgra64→rgba: SIMD vs scalar mismatch");
}

Expand All @@ -231,8 +231,8 @@ fn neon_bgra64_to_rgb_u16_matches_scalar_width17() {
let src = make_rgba64_src(17, 0x9ABC);
let mut simd_out = std::vec![0u16; 17 * 3];
let mut scalar_out = std::vec![0u16; 17 * 3];
unsafe { neon_bgra64_to_rgb_u16_row(&src, &mut simd_out, 17) };
scalar::bgra64_to_rgb_u16_row(&src, &mut scalar_out, 17);
unsafe { neon_bgra64_to_rgb_u16_row::<false>(&src, &mut simd_out, 17) };
scalar::bgra64_to_rgb_u16_row::<false>(&src, &mut scalar_out, 17);
assert_eq!(
simd_out, scalar_out,
"bgra64→rgb_u16: SIMD vs scalar mismatch"
Expand All @@ -246,8 +246,8 @@ fn neon_bgra64_to_rgba_u16_matches_scalar_width17() {
let src = make_rgba64_src(17, 0xDEF0);
let mut simd_out = std::vec![0u16; 17 * 4];
let mut scalar_out = std::vec![0u16; 17 * 4];
unsafe { neon_bgra64_to_rgba_u16_row(&src, &mut simd_out, 17) };
scalar::bgra64_to_rgba_u16_row(&src, &mut scalar_out, 17);
unsafe { neon_bgra64_to_rgba_u16_row::<false>(&src, &mut simd_out, 17) };
scalar::bgra64_to_rgba_u16_row::<false>(&src, &mut scalar_out, 17);
assert_eq!(
simd_out, scalar_out,
"bgra64→rgba_u16: SIMD vs scalar mismatch"
Expand All @@ -265,8 +265,8 @@ fn neon_rgb48_to_rgb_exact8_matches_scalar() {
let src = make_rgb48_src(8, 0xF0F0);
let mut simd_out = std::vec![0u8; 8 * 3];
let mut scalar_out = std::vec![0u8; 8 * 3];
unsafe { neon_rgb48_to_rgb_row(&src, &mut simd_out, 8) };
scalar::rgb48_to_rgb_row(&src, &mut scalar_out, 8);
unsafe { neon_rgb48_to_rgb_row::<false>(&src, &mut simd_out, 8) };
scalar::rgb48_to_rgb_row::<false>(&src, &mut scalar_out, 8);
assert_eq!(
simd_out, scalar_out,
"rgb48→rgb exact-8: SIMD vs scalar mismatch"
Expand All @@ -280,8 +280,8 @@ fn neon_rgba64_to_rgba_exact8_matches_scalar() {
let src = make_rgba64_src(8, 0x0F0F);
let mut simd_out = std::vec![0u8; 8 * 4];
let mut scalar_out = std::vec![0u8; 8 * 4];
unsafe { neon_rgba64_to_rgba_row(&src, &mut simd_out, 8) };
scalar::rgba64_to_rgba_row(&src, &mut scalar_out, 8);
unsafe { neon_rgba64_to_rgba_row::<false>(&src, &mut simd_out, 8) };
scalar::rgba64_to_rgba_row::<false>(&src, &mut scalar_out, 8);
assert_eq!(
simd_out, scalar_out,
"rgba64→rgba exact-8: SIMD vs scalar mismatch"
Expand All @@ -299,8 +299,8 @@ fn neon_rgb48_to_rgb_width1_scalar_tail_only() {
let src = [0x1234u16, 0x5678, 0x9ABC];
let mut simd_out = [0u8; 3];
let mut scalar_out = [0u8; 3];
unsafe { neon_rgb48_to_rgb_row(&src, &mut simd_out, 1) };
scalar::rgb48_to_rgb_row(&src, &mut scalar_out, 1);
unsafe { neon_rgb48_to_rgb_row::<false>(&src, &mut simd_out, 1) };
scalar::rgb48_to_rgb_row::<false>(&src, &mut scalar_out, 1);
assert_eq!(
simd_out, scalar_out,
"rgb48→rgb width=1: tail-only mismatch"
Expand All @@ -314,8 +314,8 @@ fn neon_bgra64_to_rgba_u16_width1_scalar_tail_only() {
let src = [0x1111u16, 0x2222, 0x3333, 0x4444]; // B, G, R, A
let mut simd_out = [0u16; 4];
let mut scalar_out = [0u16; 4];
unsafe { neon_bgra64_to_rgba_u16_row(&src, &mut simd_out, 1) };
scalar::bgra64_to_rgba_u16_row(&src, &mut scalar_out, 1);
unsafe { neon_bgra64_to_rgba_u16_row::<false>(&src, &mut simd_out, 1) };
scalar::bgra64_to_rgba_u16_row::<false>(&src, &mut scalar_out, 1);
assert_eq!(
simd_out, scalar_out,
"bgra64→rgba_u16 width=1: tail-only mismatch"
Expand Down
Loading
Loading