Skip to content

Bounty - Pip installations#18

Merged
fakhirali merged 45 commits intoFinity-Alpha:masterfrom
SalehAhmad1:pip_installations
May 2, 2024
Merged

Bounty - Pip installations#18
fakhirali merged 45 commits intoFinity-Alpha:masterfrom
SalehAhmad1:pip_installations

Conversation

@SalehAhmad1
Copy link
Contributor

I have setup pip installations for all packages.

Things to note:

  1. Packages being shared/used by one or more modalities were set as required packages like:
  • sounddevice
  • librosa
  • torch
  • transformers
  • torchaudio
    etc
  1. Packages being used by the TTS/LLM/TTS have been setup as individual installations.
    i.e. OpenVoiceChat[piper], OpenVoiceChat[xtts], OpenVoiceChat[llama] etc etc

I have also updated the Readme.md for better understanding of the user.

@fakhirali fakhirali added the bounty PR solving a bounty problem label Apr 27, 2024
@fakhirali
Copy link
Contributor

pip installing individual libs works.

I cannot do

import OpenVoiceChat as ovc

but the following works:

import llm.llm_gpt as llm_gpt

Maybe putting all of the things into an OpenVoiceChat module works? Idk.
Ideally it is like the following:

import OpenVoiceChat as ovc
from ovc.llm import llm_gpt

@SalehAhmad1
Copy link
Contributor Author

Ok, I will update it then we'll test again.

@SalehAhmad1
Copy link
Contributor Author

SalehAhmad1 commented Apr 27, 2024

Damnn, I didn't know it updates in the same PR without me sending one again xD
Sorry for the mess!

@fakhirali
Copy link
Contributor

fakhirali commented Apr 27, 2024

Ez scene bro. Just commit to this branch and PR updates.

@SalehAhmad1
Copy link
Contributor Author

OVC can now be installed by using

Important Points:

  • All subpackages (llm, stt, tts) are included, and usable.
  • When a user initializes a chat bot let's say Chatbot_GPT in this case, a warning will be raised if openai is not installed. else it won't. Same goes for all optional requirements.

@fakhirali
Copy link
Contributor

fakhirali commented May 2, 2024

Could you add transformers as an additional dependency as well. And also do the imports in init with llm_hf.
I also feel torch is a heavy lib. When do we need it, can we remove it since transformers already requires it?
Also we are probably version 0.1 lol

Bounty Completed! 💰

@SalehAhmad1
Copy link
Contributor Author

Could you add transformers as an additional dependency as well. And also do the imports in init with llm_hf. I also feel torch is a heavy lib. When do we need it, can we remove it since transformers already requires it? Also we are probably version 0.1 lol

Bounty Completed! 💰

Files like main.py, translation.py etc import torch and use to setup compute device.

I'll add transformers as an optional dependency too, and edit the version too.

@fakhirali
Copy link
Contributor

Hmm then leave torch in for now.

@fakhirali fakhirali merged commit 3dd2104 into Finity-Alpha:master May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bounty PR solving a bounty problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants