Skip to content

Recursive scan, lazy content loading, include forks, b64 decode, catch ResolutionErrors & tweak logging 😮‍💨#4

Merged
TheTeaCat merged 16 commits intodevfrom
recursive-scan
Jun 2, 2023
Merged

Recursive scan, lazy content loading, include forks, b64 decode, catch ResolutionErrors & tweak logging 😮‍💨#4
TheTeaCat merged 16 commits intodevfrom
recursive-scan

Conversation

@TheTeaCat
Copy link
Member

@TheTeaCat TheTeaCat commented Jun 1, 2023

Blocked by #3

  • Implements scanning the repo contents recursively, as I didn't realise .get_content() isn't recursive. An alternative is to use git trees, but this was easier and works for now.
  • Makes loading the file contents lazy so the file extension is checked first before bothering to load it, as scanning repos with large irrelevant files was slow.
  • Removes skipping forked repos
  • Adds ResolutionErrors to the try catch around the prance resolution
  • Adds a missing b64 decode to file contents
  • Tweaks logging to be a bit nicer to read & output the response from the Firetail SaaS upon API creation

@TheTeaCat TheTeaCat self-assigned this Jun 1, 2023
@TheTeaCat TheTeaCat changed the title Recursive scan Recursive scan, lazy content loading, include forks, b64 decode, catch ResolutionErrors & tweak logging 😮‍💨 Jun 1, 2023
@TheTeaCat TheTeaCat marked this pull request as ready for review June 1, 2023 10:55
@TheTeaCat TheTeaCat requested a review from finnci June 1, 2023 10:55
@TheTeaCat TheTeaCat merged commit ef1483a into dev Jun 2, 2023
@TheTeaCat TheTeaCat deleted the recursive-scan branch June 2, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants