collection.update in angularFireCollection

[samlinux]

Hi,could it be possible, that in the update function there should be the update method instead of the set method ??

[anantn]

Hey @samlinux, could you elaborate a little more about why you want access to update instead of set?

[samlinux]

Hey I tried to make a list with the methods add, update and delete one item in the firebase store. I found out that my item would be duplicated in the firebase store if i use your update function, because of this I changed

item.$ref.set(copy); to
item.$ref.update(copy);

and it works for me.

I tried to update one item in my store, maybe something is going wrong in my example!

[marknutter]

@anantn update is non-destructive to other attributes on the object, whereas set will overwrite all attributes included in the object in the update. Not to mention, the angularFireCollection method is called "update" so it should be analogous to Firebase's "update" method. Instead, the angularFireCollection "update" method should be renamed to "set" and an additional "update" method should be added that actually calls Firebase's "update".

[anantn]

Thanks @marknutter - that makes a lot of sense!

[vzhen]

@anantn Can I simply change the update method from .set(copy) to .update(copy) and add a set method myself?
Will there a side-effect?
Since firebase itself supports push, remove, update, set.

And no reason for angularFire only support push, remove and a problem (update).