-
Notifications
You must be signed in to change notification settings - Fork 625
Fix primitive to object transitions. #541
Fix primitive to object transitions. #541
Conversation
Hoped it was the source of FirebaseExtended#541. It's not.
|
OK, |
src/FirebaseObject.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These deletes have to happen somewhere. I'm not sure if this is the best location. My other thought was inside the $$scopeUpdated function, but that does not have access to scope.
tests/unit/utils.spec.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first $value should be $id.
|
I'm happy with this change and it looks like you've addressed all the issue I brought up. I'll leave it to @katowulf to review and merge this guy in. |
|
@jamestalmage Attempted a manual merge here, but I can't reconcile this with your changes from #546, which removes |
|
I'll fix the merge conflicts and ping you when complete. |
|
#546 is merged into master, so that should help. |
Conflicts: src/FirebaseObject.js
|
That test doesn't fail on my machine. My output from |
|
Yep. |
Fix primitive to object transitions.
Currently only contains a failing test proving the bug exists.See #540