This repository was archived by the owner on Mar 17, 2025. It is now read-only.
FirebaseObject: simplify API #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think we should also:
|
|
|
||
| TEST(FirebaseObjectTest, GetString) { | ||
| FirebaseObject obj("\"foo\""); | ||
| EXPECT_EQ("foo", obj.getString()); |
Collaborator
There was a problem hiding this comment.
We should have tests that test a deeper object path like user/name/first or something deeper than one, make sure our path parsing is correct.
Contributor
Author
There was a problem hiding this comment.
GetObject tests /foo/bar below.
Do you mean we should test error when going too deep?
Collaborator
There was a problem hiding this comment.
Edit: my mistake you do test it I just missed it.
Collaborator
There was a problem hiding this comment.
Whoops just realized that you do test "/foo/bar" equals "hop", ignore this.
Collaborator
|
LGTM, just a couple of small nits. Feel free to ignore and submit. |
- remove cast operator - remove indexing method - accept a subpath
Contributor
Author
|
Note: Also updated the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133 #109