-
Notifications
You must be signed in to change notification settings - Fork 488
Update neopixel sample #145
Conversation
| @@ -0,0 +1,65 @@ | |||
| // | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you "git mv" (Like it looks like you did with the rest of the directory these shouldn't we keep the history?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the file change too much, git will consider it's a new file (see http://stackoverflow.com/a/433142)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems to be discussing when you do git rm/add I think if you do "git mv" than it will explicitly keep the link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly no:
https://git.wiki.kernel.org/index.php/GitFaq#Why_does_Git_not_.22track.22_renames.3F
Git has a rename command git mv, but that is just for convenience. The effect is indistinguishable from removing the file and adding another with different name and the same content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, crappy :( didn't know that.
|
LGTM aside from the move vs delete/copy issue. |
- remove colors_ext.h deps
- rename www to public - add arduino and firebase hosting instructions
479a967 to
a36e139
Compare
Fixes #135
/cc @gguuss