Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

Conversation

@proppy
Copy link
Contributor

@proppy proppy commented May 16, 2016

Fixes #135

/cc @gguuss

@proppy proppy added this to the lego-workshop milestone May 16, 2016
@@ -0,0 +1,65 @@
//
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you "git mv" (Like it looks like you did with the rest of the directory these shouldn't we keep the history?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the file change too much, git will consider it's a new file (see http://stackoverflow.com/a/433142)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems to be discussing when you do git rm/add I think if you do "git mv" than it will explicitly keep the link.

Copy link
Contributor Author

@proppy proppy May 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly no:
https://git.wiki.kernel.org/index.php/GitFaq#Why_does_Git_not_.22track.22_renames.3F

Git has a rename command git mv, but that is just for convenience. The effect is indistinguishable from removing the file and adding another with different name and the same content.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, crappy :( didn't know that.

@ed7coyne
Copy link
Collaborator

LGTM aside from the move vs delete/copy issue.

@proppy proppy force-pushed the update-neopixel branch 2 times, most recently from 479a967 to a36e139 Compare May 17, 2016 06:36
@proppy proppy force-pushed the update-neopixel branch from a36e139 to c1547e2 Compare May 17, 2016 06:38
@proppy proppy merged commit 045e9a9 into FirebaseExtended:master May 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants