This repository was archived by the owner on Mar 17, 2025. It is now read-only.
Drop Arduino strings on our internal libraries. #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is present upstream
|
|
||
| void FirebaseArduino::setString(const String& path, const String& value) { | ||
| JsonVariant json(value); | ||
| JsonVariant json(value.c_str()); |
Collaborator
Author
There was a problem hiding this comment.
This one is odd because it is a pre-existing bug. If you pass JasonVariant an Arduino String it will always interpret it as bool (at least it does for the string in FirebaseDemo).
|
|
||
| // update value | ||
| Firebase.setFloat("number", 43.0); | ||
| // handle error |
Contributor
There was a problem hiding this comment.
maybe we should split that in a different PR?
Collaborator
Author
There was a problem hiding this comment.
Split this one out.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think copying is kept reasonable. .c_str() will return a pointer to internal state according to c++11 spec. Assuming it is similar on Arduino String.
Addresses #117