Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

Conversation

@ed7coyne
Copy link
Collaborator

Not sure if this is ready yet, only way I know to test is have it run against a PR.

.travis.yml Outdated
# Need sudo for trusty.
sudo: required
# Trusty gives us GCC 4.8 which supports c++11.
dist: trusty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we should be able to get modern gcc w/o sudo with addons: apt: see http://genbattle.bitbucket.org/blog/2016/01/17/c++-travis-ci/

Copy link
Collaborator Author

@ed7coyne ed7coyne Apr 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya I was playing with that when I last worked on this. I couldn't seem to get it to pass validation (http://lint.travis-ci.org/) so I was trying to figure out if I did something wrong. I will just try committing it to this PR and see if it works.

This way works but it takes longer to schedule it seems.

@ed7coyne
Copy link
Collaborator Author

The core of this PR is ready, unfortunately the tests are failing due to the "ERROR: this mock object (used in test GetCommandTest.gets) should be deleted but never is. Its address is @0x99ea60" issues I was ignoring before. I am working on fixing those before merging this.

@ed7coyne ed7coyne assigned ed7coyne and proppy and unassigned ed7coyne Apr 29, 2016
@ed7coyne
Copy link
Collaborator Author

This PR is ready.

- ARDUINO_VERSION=1.6.8 ARDUINO_ESP8266_VERSION=2.2.0-rc1 ARDUINO_ROOT=${HOME}/arduino-${ARDUINO_VERSION} ARDUINO_ESP8266_ROOT=${ARDUINO_ROOT}/hardware/esp8266com/esp8266 ARDUINO_HOME=${HOME}/Arduino
- ARDUINO_VERSION=nightly ARDUINO_ESP8266_VERSION=master ARDUINO_ROOT=${HOME}/arduino-${ARDUINO_VERSION} ARDUINO_ESP8266_ROOT=${ARDUINO_ROOT}/hardware/esp8266com/esp8266 ARDUINO_HOME=${HOME}/Arduino
install:
- if [ "$CXX" = "g++" ]; then export CXX="g++-4.8" CC="gcc-4.8"; fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's nice with keeping g++ in the env is that we can try with different version, I guess we can introduce it later when we actually text multiple version :)

@proppy
Copy link
Contributor

proppy commented Apr 29, 2016

LGTM

@proppy proppy merged commit 7f62a32 into FirebaseExtended:master Apr 29, 2016
@ed7coyne ed7coyne deleted the tests-travis branch June 17, 2016 16:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants