Fix usingFirebaseJsSdk
#84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexastrum
approved these changes
Jun 24, 2023
| } catch (e) { | ||
| return false; | ||
| } | ||
| } No newline at end of file |
Collaborator
There was a problem hiding this comment.
Nit: line break at end of files.
Contributor
Author
There was a problem hiding this comment.
I see, there's no prettier config in this repo though, we should add it, probably use the same config as the CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from
process.env.__FIREBASE_DEFAULTS__, check whether the Firebase JS SDK can be imported to assume that the app is using it. In some cases the env. variable was set even if the app was not using the Firebase JS SDK.Fixes firebase/firebase-tools#5996