Skip to content

Conversation

@DellaBitta
Copy link
Collaborator

@DellaBitta DellaBitta commented Jul 28, 2025

New Data Connect tests for Next.js

  • Added Create, List and Delete tests for Data Connect.
  • Pulled Data Connect auto generated files from a Data Connect test in the Firebase JS SDK .
  • Added a new nextjs:dev target in thepackage.json to easily start the Next.js test app in local environments.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @DellaBitta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the testing infrastructure by incorporating Data Connect functionality into the existing Next.js nightly test suite. It introduces a new, auto-generated JavaScript SDK that facilitates interaction with Data Connect for common operations like creating, listing, and deleting data, thereby enhancing the robustness and coverage of our automated tests.

Highlights

  • New Data Connect Test Integration: This PR integrates Data Connect tests, specifically for Create, List, and Delete operations, into the Next.js nightly test framework.
  • Generated SDK for Data Connect: A new generated JavaScript SDK for a 'tests' connector has been added, providing programmatic access to defined Data Connect queries and mutations.
  • Multi-Environment Support: The generated SDK includes both ECMAScript Module (ESM) and CommonJS (CJS) versions, along with TypeScript declaration files, ensuring broad compatibility.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds generated JavaScript SDK files for a new 'tests' Data Connect connector. The changes appear to be entirely auto-generated. My review focuses on the consistency and correctness of these generated files based on the provided context. I've identified a potential issue with an extraneous query being included in the generated SDK.

@DellaBitta DellaBitta requested a review from hsubox76 July 29, 2025 15:05
@DellaBitta DellaBitta changed the title feat: Add Data Connect to Nextjs test framework feat(nextjs): Add Data Connect to Nextjs test framework Jul 29, 2025
@DellaBitta DellaBitta merged commit 32c265b into main Jul 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants