-
Notifications
You must be signed in to change notification settings - Fork 0
[chore] Bump Next.js to v15.5.2 #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @DellaBitta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on a routine dependency update, specifically upgrading the Next.js framework and its related ecosystem packages to their latest stable versions. This ensures the local development environment benefits from the newest features, performance improvements, and bug fixes provided by the updated libraries.
Highlights
- Next.js Version Bump: The core Next.js framework has been updated from version 15.4.1 to 15.5.2.
- Related Next.js Dependencies Updated: Associated Next.js packages, including @next/env and various @next/swc-* platform-specific binaries, have also been bumped to version 15.5.2 to maintain compatibility.
- Yarn Lockfile Structure Refinement: The yarn.lock file has been adjusted to separate previously combined entries for 'string-width-cjs', 'strip-ansi-cjs', and 'wrap-ansi-cjs', improving clarity and consistency in dependency resolution.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates Next.js to version 15.5.2. The changes in yarn.lock correctly reflect this update. I have added one comment regarding a related dependency, eslint-config-next, which should also be updated to maintain consistency and ensure correct linting rules are applied.
| version "15.4.1" | ||
| resolved "https://registry.yarnpkg.com/next/-/next-15.4.1.tgz#05c96856177b5077d98de1714a3e414b7b0959f3" | ||
| integrity sha512-eNKB1q8C7o9zXF8+jgJs2CzSLIU3T6bQtX6DcTnCq1sIR1CJ0GlSyRs1BubQi3/JgCnr9Vr+rS5mOMI38FFyQw== | ||
| version "15.5.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the next package is being updated to version 15.5.2, the eslint-config-next package in js-sdk-framework-tests/nextjs/package.json remains at version 14.2.13. It's important to keep the ESLint configuration aligned with the Next.js version to ensure correct linting rules are applied and avoid potential issues. Please consider updating eslint-config-next to match the new Next.js version, for example to ^15.5.2 or latest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated eslint, too. Thanks Gemini Code Assist. You're the best.
Update the resolved version of Next.js to
15.5.2for local development.Also update
eslint-nextto match.