'changed_contribution_steps' #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuleatt
reviewed
Oct 31, 2019
README.md
Outdated
Comment on lines
95
to
96
| 1. Fork this repository using by clicking _Fork_ button at the top | ||
| 1. Clone your own version on repository by using `git clone https://github.com/<username>/reactfire.git` (replace the repo url with your own version's url) |
Collaborator
There was a problem hiding this comment.
I think we can simplify the first two down to:
1. [Clone](https://help.github.com/en/github/creating-cloning-and-archiving-repositories/cloning-a-repository) this repository (or a [fork](https://help.github.com/en/github/getting-started-with-github/fork-a-repo#propose-changes-to-someone-elses-project))Which will look like this:
jhuleatt
reviewed
Oct 31, 2019
README.md
Outdated
| 1. At the project root, run `yarn install` | ||
| 1. Fork this repository using by clicking _Fork_ button at the top | ||
| 1. Clone your own version on repository by using `git clone https://github.com/<username>/reactfire.git` (replace the repo url with your own version's url) | ||
| 1. At the project root, install all modules by running `yarn install` or `npm install` |
Collaborator
There was a problem hiding this comment.
Please remove npm install. This project uses a yarn workspace so npm install likely won't work.
Collaborator
|
Thanks for the PR, @catrawalkar! I've added a few comments, but once you update those things I'll merge this. |
Contributor
Author
|
@jhuleatt done :) |
jhuleatt
approved these changes
Nov 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just getting started, so just added few documentation lines.