Skip to content

Conversation

@timotius02
Copy link
Contributor

"Warning: bind(): React component methods may only be bound to the component instance." was popping up in both todoApp2 & todoApp3 because the "removeItem" onClick handlers were unnecessarily trying to bind to the component itself.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jwngr
Copy link

jwngr commented Aug 24, 2015

Thanks for the PR. I do see the warning now. I'll go ahead and merge this in once you sign the Google CLA.

Also, I see there are some extraneous console.log() messages in the removeItem() methods in both files. Would you mind removing them in this PR as well? Thanks!

@googlebot
Copy link

CLAs look good, thanks!

@timotius02
Copy link
Contributor Author

Removed the console.logs. Not sure why the checks failed but hopefully it wasn't anything I did.
Edit: Nevermind it's fixed.

jwngr pushed a commit that referenced this pull request Aug 24, 2015
fix bind warning in todoApp example
@jwngr jwngr merged commit 2986f82 into FirebaseExtended:master Aug 24, 2015
@jwngr
Copy link

jwngr commented Aug 24, 2015

Looks like Travis just had a hiccup. I re-ran it and things passed as expected. Thanks!

@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants