Skip to content

Conversation

@gragland
Copy link

Currently the componentWillUnmount will attempt to unbind a ref that we've already called unbind on, resulting in an error. We need to skip any values within this.firebaseRefs that equal "undefined". Alternatively we could change unbind to delete the ref from this.firebaseRefs (it looks like it used to be that way and was changed for some reason).

Currently the componentWillUnmount will attempt to unbind a ref that we've already called unbind on, resulting in an error.
We need to skip any values within this.firebaseRefs that equal "undefined". Alternatively we could change unbind to delete the ref from this.firebaseRefs (it looks like it used to be that way and was changed for some reason).
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@gragland
Copy link
Author

I signed the Contributor License Agreement.

@jwngr
Copy link

jwngr commented Sep 29, 2015

Thanks for pointing this out and taking a crack at it. I created #69 based of your PR so that I can get out a new version. Release going out now. Thanks for the contribution!

@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants