Skip to content

Conversation

@asfernandes
Copy link
Member

No description provided.

@asfernandes asfernandes requested a review from fdcastel May 3, 2025 18:23
@fdcastel
Copy link
Member

fdcastel commented May 4, 2025

I'm abroad and unable to test this now. However, I was under the impression that the --rm flag would remove any anonymous volumes created?

That said, it looks good to me -- Go ahead if this has caused issues for you and/or it would help keep the current build environment clean. 👍🏻

@asfernandes
Copy link
Member Author

No, volumes declared in the Dockerfile were left, causing docker volume ls to show many volumes created in the tests.

@asfernandes
Copy link
Member Author

it would help keep the current build environment clean.

GitHub build is ephemeral, I was more worried about local builds.

@asfernandes asfernandes merged commit 9861a3d into master May 4, 2025
1 check passed
@asfernandes asfernandes deleted the work/test-temp-volume branch May 4, 2025 22:47
jure-ve added a commit to jure-ve/firebird-docker-img that referenced this pull request May 10, 2025
Avoid creating numerous volumes during test execution (FirebirdSQL#22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants