Use exception instead bugcheck for EVL_expr [CORE5563]

[firebird-automations]

Submitted by: Maxim Kuzmin (cybermax)

For some querys, Firebird stopped with bugcheck for error at EVL_expr:
SERVER (Server) Tue Nov 08 14:00:41 2016
Database: --DATABASE--
internal Firebird consistency check (EVL_expr: invalid operation (232), file: evl.cpp line: 1219)

SERVER (Server) Tue Nov 08 14:00:41 2016
Database: --DATABASE--
internal Firebird consistency check (EVL_expr: invalid operation (232), file: evl.cpp line: 1219)

SERVER (Server) Tue Nov 08 14:05:29 2016
Database: --DATABASE--
internal Firebird consistency check (can't continue after bugcheck)

SERVER (Server) Tue Nov 08 14:05:29 2016
Database: --DATABASE--
internal Firebird consistency check (can't continue after bugcheck)

SERVER (Server) Tue Nov 08 14:05:29 2016
Database: --DATABASE--
internal Firebird consistency check (can't continue after bugcheck).

For this error, it is not necessary to stop the server with hundreds of users, sufficiently raising the exception at executing query.

Commits: c28e734

====== Test Details ======

Ability to use nested aggregate looks strange (IMO).
Query like here can not be run in MS SQL or Postgress.
Sent letters to dimitr, 19.06.2018.

Also, see note 22/Jun/17 09:10 AM in this ticket.

[firebird-automations]

Commented by: Maxim Kuzmin (cybermax)

For example, this query stopping FB 2.5.6 with bugcheck:
SELECT
SUM(SUM((SELECT SUM(RF.RDB$FIELD_POSITION) FROM RDB$RELATION_FIELDS RF)))
FROM
RDB$DATABASE

[firebird-automations]

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Alpha 1 [ 10731 ]

assignee: Adriano dos Santos Fernandes [ asfernandes ]

[firebird-automations]

Commented by: @pavel-zotov

Check following sample:

set list on;

-- query from ticket:
select sum(sum((select sum(rf.rdb$field_position) from rdb$relation_fields rf))) as sf from rdb$database;
--select sign( sum( sum( ( select sum(rf.rdb$field_position) from rdb$relation_fields rf) ) ) ) as sf from rdb$database;

set echo on;

select sum( 1 ) as s01 from rdb$database rd;
select sum( rf.rdb$field_position ) as s01 from rdb$relation_fields rf;

----------------------------------------------------------------------

select sum( ( select sum( 1 ) from rdb$database rd ) ) as s02 from rdb$database;
select sum( ( select sum( rf.rdb$field_position ) from rdb$relation_fields rf) ) as s02 from rdb$database;

----------------------------------------------------------------------

select sum( sum( (select sum( 1 ) from rdb$database rd ) ) ) as s03 from rdb$database;
select sum( sum( (select sum( rf.rdb$field_position ) from rdb$relation_fields rf ) ) ) as s03 from rdb$database;

Last two statements will finish with this:

===
select sum( sum( (select sum( 1 ) from rdb$database rd ) ) ) as s03 from rdb$database;
Statement failed, SQLSTATE = 42000
Dynamic SQL Error
-SQL error code = -104
-Nested aggregate and window functions are not allowed

select sum( sum( (select sum( rf.rdb$field_position ) from rdb$relation_fields rf ) ) ) as s03 from rdb$database;

S03 <null> -------------------------------- ???

Why we can see here "S03 <null>" (and it's what source query returns) ?

PS. WI-T4.0.0.680, WI-V3.0.3.32738

[firebird-automations]

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Deferred

Test Details: See note 22/Jun/17 09:10 AM

[firebird-automations]

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: Deferred => Done with caveats

Test Details: See note 22/Jun/17 09:10 AM => Ability to use nested aggregate looks strange (IMO).
Query like here can not be run in MS SQL or Postgress.
Sent letters to dimitr, 19.06.2018.

Also, see note 22/Jun/17 09:10 AM in this ticket.

[firebird-automations]

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]