Skip to content

Unit tests (start) with Boost.Test and build improvements #7235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Aug 2, 2022
Merged

Unit tests (start) with Boost.Test and build improvements #7235

merged 21 commits into from
Aug 2, 2022

Conversation

@asfernandes
Copy link
Member

@asfernandes asfernandes commented Jul 21, 2022 •
edited
Loading

  • Added Boost.Test library and some tests for common and engine
  • Structured Windows VS solution in groups (LIBs, DLLs, EXEs, Tests)
  • Build and use static libc++ in GitHub Actions MacOS build
  • Improve GitHub Actions MacOS build speed caching libicu build
  • Removed old things from Windows build

asfernandes added 21 commits July 18, 2022 08:16
@asfernandes
Move gds.cpp to common.
f296f44
@asfernandes
Move gds_proto.h to common.
8740a38
@asfernandes
Import boost_1_79_0 test and dependent library's headers using bcp.
6a8de73
@asfernandes
Add test framework in common library.
bb5a1e0
@asfernandes
Add tests for common/classes/Aligner.
2139d4a
@asfernandes
Add tests for common/classes/Array.
5e13cb6
@asfernandes
Add methods to DoublyLinkedList.
f18f5eb
@asfernandes
Add tests for common/classes/DoublyLinkedList.
b4ba747
@asfernandes
Add test framework in engine library.
76dbad5
@asfernandes
Add tests for jrd/RecordNumber.
cf63ea5
@asfernandes
Separate projects in groups in Firebird.sln.
ef361bc
@asfernandes
Put tests in Firebird.sln.
ecbbc9a
@asfernandes
Remove old and unused things from the Windows build.
3dda315
@asfernandes
Correction in GH Actions Windows workflow.
cae5a21
@asfernandes
Update Linux builder Dockerfile - should update and push the image.
bb16777
@asfernandes
Move tests directory to avoid problem with non-system shared libraries.
78b95b3
@asfernandes
Build and use static libc++ in MacOS.
637c924 
We are already using static libstdc++ in Linux due to a problem
now appearing in MacOS when using Boost.Test.

When shared C++ library (with C++ interface) is used and
executable does not export its new/delete operators, a situation
of one program/library allocating objects with "new" operator
and another program/library deallocating them with "delete"
operator makes program to crash.

We haven't yet seen these crashes in Windows, even using
Boost.Test. That may be pure luck or because Microsoft std C++
library is coded in a way that makes it not happen.
@asfernandes
Cache MacOS libicu build in GitHub Action.
3028ec9
@asfernandes
Revert "Move gds_proto.h to common."
f93852a 
This reverts commit 8740a38.
@asfernandes
Revert "Move gds.cpp to common."
28058cf 
This reverts commit f296f44.
@asfernandes
Reference gds.cpp in src/yvalve.
30ff90b
@asfernandes asfernandes merged commit 1f432c8 into master Aug 2, 2022
@asfernandes asfernandes deleted the work/boost-test branch August 2, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asfernandes @AlexPeshkoff