Fix resetting and accidental key damaging/deleting (#7415) #7423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should add key correctness check in case of resetting encryption key on Classic server with multiple attachments, and hanging Super server in case of accidental key damaging/deleting
src/jrd/CryptoManager.cpp
Outdated
| else | ||
| hash = valid; | ||
| { | ||
| if (!keyName.isEmpty()) |
Member
There was a problem hiding this comment.
I doubt about this check. Crypt plugin may use unnamed key which also can be changed.
AlexPeshkoff
requested changes
Dec 20, 2022
Member
AlexPeshkoff
left a comment
AlexPeshkoff
left a comment
There was a problem hiding this comment.
To be accepted PR should be also done for fb4 & 5.
AlexPeshkoff
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should add key correctness check in case of resetting encryption key on Classic server with multiple attachments, and hanging Super server in case of accidental key damaging/deleting