remove redundant plugin reload on super server #8393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssic after stateLock ast
Member
|
Code is OK - but why fb5? Where is master? |
Contributor
Author
|
I decided to create a PR in fb5 first because that's the version where I discovered the behavior described in issue #8389. If there are no questions about the code, I can create PRs for other branches as well. |
Member
|
No need in extra PRs, I will front-port the commit myself. |
Member
OK, please do. BTW, suppose old versions may also be affected. |
dyemanov
pushed a commit
that referenced
this pull request
Jan 16, 2025
…ssic after stateLock ast (#8393) Co-authored-by: aleksey.mochalov <aleksey.mochalov@red-soft.ru>
dyemanov
pushed a commit
that referenced
this pull request
Jan 20, 2025
…ssic after stateLock ast (#8393) Co-authored-by: aleksey.mochalov <aleksey.mochalov@red-soft.ru>
dyemanov
pushed a commit
that referenced
this pull request
Jan 20, 2025
…ssic after stateLock ast (#8393) Co-authored-by: aleksey.mochalov <aleksey.mochalov@red-soft.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8389. It removes unnecessary plugin reloads in the SuperServer and introduces a special flag to update plugins in the Classic Server after the stateLock ast event.