CFDP Class 1 Fixes#7
Merged
pepepr08 merged 6 commits intocfdp_managerfrom Mar 27, 2026
Merged
Conversation
pepepr08
force-pushed
the
cfdp_xfer_fixes
branch
from
d7d8ea9 to
a4ba48e
Compare
pepepr08
force-pushed
the
cfdp_xfer_fixes
branch
from
a4ba48e to
471415a
Compare
pepepr08
force-pushed
the
cfdp_xfer_fixes
branch
from
471415a to
f5f6aa3
Compare
Collaborator
Author
|
We will merge this in favor of keep making progress and have an easier integration later on. This code is being merged to the intermediate cfdp_manager branch, and will be reviewed anyway when we do a larger review of the cfdp component as a whole. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Depends on #2, #3, #4
Fixes to class 1 transactions.
Rationale
Fixes a bug where we weren't properly handling the throttle limit of max outgoing pdus per cycle. Once the limit was reached, the code didn't know how to properly exit the loop and wait until the next cycle.
Also includes features to send an event when transaction starts/completes. More verbose output.
Testing/Review Recommendations
Future Work
AI Usage (see policy)