Feat: app attest counter #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DB value, add mock_response to chat_request class, bugfixes
subpath
reviewed
Nov 12, 2025
subpath
reviewed
Nov 12, 2025
| UPDATE public_keys | ||
| SET counter = $2, | ||
| updated_at = NOW() | ||
| WHERE key_id_b64 = $1 |
Collaborator
There was a problem hiding this comment.
Request:
I think this creates race condition 🤔
If there will be 2 parallel requests with the same key_id, then we will have duplicated assertion with the same counter
WHERE key_id_b64 = $1 AND counter < $2
maybe we need this condition? WDYT?
Collaborator
Author
There was a problem hiding this comment.
Works for me
subpath
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
appattestDB migration to add counter to public_keysfor App Attest/Assert replay attack protection
ChatRequest/AuthorizedChatRequestflow to carry optionalmock_responsedata through completions.behavior and added coverage for replay protection.