Polish auto-hide nav buttons (fixes on top of #22)#23
Merged
Conversation
Added
--uc-tab-min-width: 36px;
.tabbrowser-tab:not([pinned]) {
min-width: var(--uc-tab-min-width) !important;
}
Match the selector to the adjacent max-width rules so the min-width does not fight collapsed tab-group collapse-to-zero or apply during the tab close animation.
Adds back function to --uc-autohide-nav-buttons: 1; One issue is that the solution messes up the spacing between navigation buttons
0 = always show, 1 = reveal with hover and focus, 2 = reveal with only hover One issue is that spacing between the buttons gets removed
Polish on top of #22 (DeathMurderGod). Fixes: - Restore native button widths via revert instead of hardcoded 32px; reload was rendered too narrow - Restore back button's 8px native leading padding (revert misses the asymmetric value), fixing the arrow gluing to the window edge - Dim disabled back/forward on reveal instead of forcing full opacity, restoring the native greyed-out cue - Animate the reveal via a fixed max-width cap so the slide survives revert - Drop margin:0 from collapse, normalize config whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Polishes and fixes the auto-hide / hide navigation buttons feature from #22. Thanks @DeathMurderGod for the original implementation and the three-mode design.
This branch builds directly on #22's commits, so merging it lands that work too. Supersedes #22.
Fixes on top of #22
revertinstead of the hardcoded32px, which was smaller than the native button.#back-button8px of leading padding (vs 2px on the others).revertmisses that asymmetric value, so it is restored explicitly.revertcan't animate from 0, so the reveal uses a fixedmax-widthcap as the animatable bound.margin: 0from the collapse and normalizes config whitespace.Notes
Default stays
0(feature off). Opt-in via--uc-autohide-nav-buttons(1 = hover + focus, 2 = hover only) and--uc-hide-nav-buttons(permanent hide). Verified on Firefox ESR 151, all three modes.