Skip to content

Add desktop launcher integration and update AUR build scripts#158

Merged
Firstp1ck merged 12 commits intoFirstp1ck:mainfrom
smrini:main
Apr 17, 2026
Merged

Add desktop launcher integration and update AUR build scripts#158
Firstp1ck merged 12 commits intoFirstp1ck:mainfrom
smrini:main

Conversation

@smrini
Copy link
Copy Markdown
Contributor

@smrini smrini commented Apr 16, 2026

Summary

This PR consolidates multiple packaging and release improvements, adding proper Linux desktop integration and bringing the AUR PKGBUILD handlers up to date:

  • Desktop Integration: Added pacsea.desktop and a new pacsea.svg app icon.
  • Release Documentation: Generated the CHANGELOG.md and added v0.8.2 release notes (RELEASE_v0.8.2.md).
  • PKGBUILD Enhancements (PKGBUILD-bin & PKGBUILD-git):
    • Updated the repository URLs to point to the correct upstream GitHub source (https://github.com/Firstp1ck/Pacsea).
    • Implemented the installation logic for the .desktop file and SVG icon during the package() phase.
    • Cleaned up obsolete post_install, post_upgrade, and post_remove hooks (modern ALPM handles desktop-database and icon-cache updates natively).
    • Re-factored the source function and git pull sequence in the git builder handling.
    • Added explicit ARM (aarch64) architecture support to PKGBUILD-git.
    • Refined git sparse-checkout in PKGBUILD-git to also ignore the dev folder to save fetch time and build space.
  • Dev Tools: Updated Makefile to support these project structure additions.

Type of change

  • feat (new feature)
  • fix (bug fix)
  • docs (documentation only)
  • refactor (no functional change)
  • perf (performance)
  • test (add/update tests)
  • chore (build/infra/CI)
  • ui (visual/interaction changes) (Added application icon for DEs)
  • breaking change (incompatible behavior)

How to test

  1. Inspect the added desktop integrations.

  2. Formulate local test builds for the updated AUR scripts:

    make install
    makepkg -si -p PKGBUILD-git
    makepkg -si -p PKGBUILD-bin
  3. After installing one of the built packages, verify that the application correctly populates your Desktop Environment's app launcher with the Pacsea icon.

Checklist

Code Quality:

  • Code compiles locally (cargo check)
  • cargo fmt --all ran without changes
  • cargo clippy --all-targets --all-features -- -D warnings is clean
  • cargo test -- --test-threads=1 passes
  • Complexity checks pass for new code (cargo test complexity -- --nocapture)
  • All new functions/methods have rustdoc comments (What, Inputs, Output, Details)
  • No unwrap() or expect() in non-test code

Testing:

  • Added or updated tests where it makes sense
  • Tests are meaningful and cover the functionality

Documentation:

  • Updated README if behavior, options, or keybinds changed (keep high-level, reference wiki)
  • Updated config examples in config directory if config keys changed
  • For UI changes: included screenshots and updated Images if applicable (New Icon applied)

Compatibility:

  • Changes respect --dry-run flag
  • Code degrades gracefully if pacman/paru/yay are unavailable
  • No breaking changes (or clearly documented if intentional)

Security (CI):

  • Ran security-check.sh before opening the PR (local mirror of the Security workflow: rustfmt, clippy, cargo audit, cargo deny check, gitleaks)
  • After adding or updating dependencies: cargo audit and cargo deny check pass
  • No secrets or credential-like placeholders that would trip gitleaks
  • Follows secure coding rules in AGENTS.md / CLAUDE.md

Other:

  • Not a packaging change for AUR (otherwise propose in pacsea-bin or pacsea-git repos) (These are internal PKGBUILD maintenance updates tied directly to the data asset implementations).

Notes for reviewers

  • Check PKGBUILD-bin and PKGBUILD-git diffs to ensure source() links are formatted exactly as expected for your internal deployment tools.

Breaking changes

None.

Additional context

Release versions incremented respectively for the v0.8.2 push, accompanied by changelog additions spanning previous commits.

Copilot AI review requested due to automatic review settings April 16, 2026 21:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds desktop launcher integration for Pacsea and updates the Arch/AUR packaging/build tooling to ship the .desktop entry and app icon alongside the binary.

Changes:

  • Add a new data/pacsea.desktop launcher and data/assets/pacsea.svg icon.
  • Extend the dev Makefile with an install-desktop target and adjust install behavior.
  • Update PKGBUILD-bin / PKGBUILD-git to install the desktop entry and icon, plus related build/source adjustments; add v0.8.2 release notes and changelog entry.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
dev/Makefile Adds install-desktop and updates install path usage for cargo install.
data/pacsea.desktop New desktop entry for launcher integration.
data/assets/pacsea.svg New SVG application icon.
PKGBUILD-git Updates git PKGBUILD (arch list, sparse checkout fetch, build env tweaks, installs desktop assets).
PKGBUILD-bin Updates binary PKGBUILD (per-arch binaries, packaging paths, installs desktop assets).
Release-docs/RELEASE_v0.8.2.md Adds release notes for v0.8.2.
CHANGELOG.md Adds v0.8.2 changelog entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dev/Makefile
Comment thread PKGBUILD-bin
Comment thread PKGBUILD-bin
Comment thread PKGBUILD-git
Comment thread PKGBUILD-git Outdated
Comment thread dev/Makefile
Comment thread PKGBUILD-bin Outdated
Comment thread src/Pacsea Outdated
Comment thread PKGBUILD-bin Outdated
Comment thread PKGBUILD-git Outdated
@Firstp1ck Firstp1ck self-assigned this Apr 16, 2026
@Firstp1ck Firstp1ck added enhancement New feature or request community-suggestions improve-consistency dev-consistency improvemet development consistency labels Apr 16, 2026
@Firstp1ck
Copy link
Copy Markdown
Owner

will fix failed ci/cd runs myself, just ignore

Comment thread PKGBUILD-git Outdated
Comment thread PKGBUILD-git Outdated
Comment thread data/assets/pacsea.svg
Copy link
Copy Markdown
Owner

@Firstp1ck Firstp1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you for the contribution, and sorry for all the small nitpicks 😄

As for the permissions. I will create an issue on it for later.

@smrini
Copy link
Copy Markdown
Contributor Author

smrini commented Apr 17, 2026

It was a great experience working with you! and I'll be always open to collaborate again, so feel free to reach out anytime if you need any more changes.

@Firstp1ck Firstp1ck merged commit 35a0dda into Firstp1ck:main Apr 17, 2026
9 of 10 checks passed
Firstp1ck added a commit that referenced this pull request Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-suggestions dev-consistency improvemet development consistency enhancement New feature or request improve-consistency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants