Skip to content

fix/sub class picker#123

Merged
lucas-baran merged 11 commits intodevelopfrom
fix/sub_class_picker
Apr 29, 2025
Merged

fix/sub class picker#123
lucas-baran merged 11 commits intodevelopfrom
fix/sub_class_picker

Conversation

@lucas-baran
Copy link
Copy Markdown
Contributor

@lucas-baran lucas-baran commented Apr 18, 2025

[2.3.2] - 2025-04-18

Updated

  • Update SubAssetPicker drawer to display mixed values and disable picker when multiple objects with different values are selected

Fixed

  • Fix SubAssetPicker would not work with items of serialized lists and arrays
  • Fix SubAssetPicker would not search for derived classes in other assemblies than the base type's assembly
  • Fix tried to show the SubAssetPicker context menu as many times as there are derived types

This change is Reviewable

@lucas-baran lucas-baran requested a review from a team April 18, 2025 16:10
@fishingcactus-nathan-istace
Copy link
Copy Markdown
Contributor

Editor/PropertyDrawer/AttributesDrawer/SubClassPickerDrawer.cs line 60 at r1 (raw file):

                if( EditorGUI.DropdownButton( drop_down_rect, new( type_name ), FocusType.Keyboard ) )
                {
                    Debug.Log( property.managedReferenceId );

Do we want to keep this debug line?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lucas-baran)

Copy link
Copy Markdown
Contributor

@LeanderSimonart LeanderSimonart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lucas-baran)

Copy link
Copy Markdown
Contributor Author

@lucas-baran lucas-baran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @fishingcactus-nathan-istace)


Editor/PropertyDrawer/AttributesDrawer/SubClassPickerDrawer.cs line 60 at r1 (raw file):

Previously, fishingcactus-nathan-istace (NathanIstace) wrote…

Do we want to keep this debug line?

No we don't

Copy link
Copy Markdown
Contributor

@PetitT PetitT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @fishingcactus-nathan-istace)

@lucas-baran lucas-baran merged commit 0811fc9 into develop Apr 29, 2025
1 check was pending
@lucas-baran lucas-baran deleted the fix/sub_class_picker branch April 29, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants