[codex] Clarify Bun install still requires Node#1032
Conversation
📝 WalkthroughWalkthroughThe PR creates a Changesets entry file and adds a platform/runtime compatibility clarification to the installation documentation, stating that Node.js 20.19.0+ is required at runtime even when installing via Bun. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/installation.md (1)
29-34: ⚡ Quick winClarify the runtime reason for the Node.js requirement.
The warning is correct, but it would be more actionable if it also explains why Node is still required (e.g., the globally installed CLI binary uses a
nodeshebang and thus needs Node onPATH). This ties directly back to#1019and reduces confusion.🛠️ Proposed docs tweak
-Bun can install OpenSpec globally, but OpenSpec currently runs on Node.js. -You still need Node.js 20.19.0 or higher available on `PATH`. +Bun can install OpenSpec globally, but running the installed `openspec` CLI still requires Node.js. +You still need Node.js 20.19.0 or higher available on `PATH` (the generated CLI is executed with Node).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/installation.md` around lines 29 - 34, Update the paragraph that currently states "Bun can install OpenSpec globally, but OpenSpec currently runs on Node.js. You still need Node.js 20.19.0 or higher available on `PATH`." to explicitly explain why Node is required: mention that the globally installed CLI binary (the package installed with `bun add -g `@fission-ai/openspec`@latest`) uses a `node` shebang and therefore requires a compatible `node` executable on the PATH (Node.js 20.19.0+), so users understand the runtime dependency and the reason behind the warning.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/installation.md`:
- Around line 29-34: Update the paragraph that currently states "Bun can install
OpenSpec globally, but OpenSpec currently runs on Node.js. You still need
Node.js 20.19.0 or higher available on `PATH`." to explicitly explain why Node
is required: mention that the globally installed CLI binary (the package
installed with `bun add -g `@fission-ai/openspec`@latest`) uses a `node` shebang
and therefore requires a compatible `node` executable on the PATH (Node.js
20.19.0+), so users understand the runtime dependency and the reason behind the
warning.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 334f0194-a737-4154-869d-e8cdd383ae18
📒 Files selected for processing (2)
.changeset/clarify-bun-node-runtime.mddocs/installation.md
alfred-openspec
left a comment
There was a problem hiding this comment.
Looks good. Docs-only clarification matches the runtime behavior, and CI is green.
Summary
Root Cause
Issue #1019 reports that
bun add -g @fission-ai/openspecinstalls an executable whose shebang invokesnode. That is expected for the current package because OpenSpec is a Node CLI and declaresnode >=20.19.0inengines. The docs listed Bun as an install option without making the runtime requirement explicit, which could imply Bun alone was sufficient.Closes #1019
Validation
pnpm exec changeset status --since=origin/mainNo runtime tests were run because this is a docs-only clarification.
Summary by CodeRabbit