[codex] Fix Windows workspace path CI failure#1111
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis PR fixes workspace planning detection to preserve the workspace kind when Windows short paths or symlink aliases resolve to a canonical workspace root, ensuring path spelling differences across platforms and symlinked environments do not break workspace detection. ChangesWorkspace planning detection with canonical paths
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alfred-openspec
left a comment
There was a problem hiding this comment.
Looks good. The fix keeps workspace planning comparisons in canonical path space while preserving the invocation cwd for workspace update, and the symlink-alias regression covers the Windows short/long path class. CI is green.
Summary
Fix the Windows-only main CI failure in the
CIworkflow by keeping workspace planning-home path comparisons in canonical path space.Root cause
The failing
mainrun wasCIrun26182487591on commit79303b5. Linux, macOS, lint, CodeQL, and release-prepare passed; the Windows PowerShell test leg failed.The Windows runner exposed the same workspace directory with two spellings: a short path under
C:\Users\RUNNER~1\...and the canonical long path underC:\Users\runneradmin\....findWorkspacePlanningRootSync()returned a canonical workspace root, butresolveCurrentPlanningHomeSync()compared it against the non-canonical search start. That made workspace-scopednew change --areas ...invocations fall back to repo planning mode and exit non-zero. A related config-profile assertion sawworkspace updateinvoked from the canonical root instead of the current cwd spelling.Changes
openspec workspace update.Validation
pnpm exec vitest run test/core/planning-home.test.ts test/commands/config-profile.test.ts test/commands/artifact-workflow.test.tspnpm run buildpnpm exec tsc --noEmitpnpm lintpnpm testpnpm exec changeset status --since=origin/mainSummary by CodeRabbit
Bug Fixes
Documentation