Skip to content

Fix joinPath to preserve POSIX separators #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TabishB merged 1 commit into from
Oct 10, 2025
Merged

Fix joinPath to preserve POSIX separators #145

TabishB merged 1 commit into from
Oct 10, 2025

Conversation

@TabishB
Copy link
Contributor

@TabishB TabishB commented Oct 10, 2025

Summary

  • normalize the Windows base path before joining segments
  • ensure non-Windows base paths use POSIX joining so forward slashes are preserved

Testing

  • pnpm exec vitest run test/utils/file-system.test.ts

https://chatgpt.com/codex/tasks/task_e_68e90ee903088322aed2738965a8d414

@TabishB TabishB merged commit 8c65b47 into main Oct 10, 2025
6 checks passed
@TabishB TabishB mentioned this pull request Oct 10, 2025
Merged
3 tasks
drvova pushed a commit to drvova/VovaSpec that referenced this pull request Oct 13, 2025
@TabishB
Fix cross-platform joinPath behavior (Fission-AI#145)
3206bd0
Kh05ifr4nD pushed a commit to Kh05ifr4nD/sorapec that referenced this pull request Jan 6, 2026
@TabishB
Fix cross-platform joinPath behavior (Fission-AI#145)
f51eac2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TabishB