Add capturing log writer test and expose LogSource (#9)#35
Merged
Conversation
Re-export Willow.LogSource as a public typealias so consumers implementing the public LogWriter surface can name the type without importing Willow directly, matching the sibling re-exports. Add a CapturingLogWriter test helper and a test that asserts on the exact messages and levels LoggingService forwards to its writers, closing the gap where logging tests exercised the code paths but never verified emitted output at the writer boundary. Drop the unused LoggingServiceMock subclass scaffolding in favor of the established harness pattern. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvages the still-useful parts of the stale `9-automated-testing` branch (rebased onto latest `master`) and drops what the current harness already supersedes.
Relates to #9 (NFR 2 — Automated Testing). Opening against the closed parent issue per request to track this follow-on testing work.
What changed
Verification
🤖 Generated with Claude Code