Port to Minecraft 1.21.8 + CI build & release workflow#4
Open
kiro-agent[bot] wants to merge 5 commits into
Open
Port to Minecraft 1.21.8 + CI build & release workflow#4kiro-agent[bot] wants to merge 5 commits into
kiro-agent[bot] wants to merge 5 commits into
Conversation
- minecraft_version: 1.21.4 -> 1.21.8 - fabric_version: 0.119.4+1.21.4 -> 0.130.0+1.21.8 - cloth-config-fabric: 17.0.144 -> 19.0.147 (Fabric 1.21.6-8 build) - modmenu: 13.0.3 -> 15.0.0 (1.21.8 build) - fabric.mod.json: minecraft dependency ~1.21.4 -> ~1.21.8 - README: update version references
- Builds JAR on push to mc-** branches and pull requests - Uploads JAR as workflow artifact for every build - On tag push (v*): publishes GitHub Release with the JAR attached - Uses JDK 21 (Temurin)
For pull_request events github.ref_name resolves to 'PR_NUMBER/merge' which contains a forward slash and is rejected by upload-artifact. Use 'pr-N' for PR builds and ref_name for branch/tag builds.
- mod_version: 1.0.0 -> 1.0.0-mc1.21.8 so Loom outputs pingdisplay-1.0.0-mc1.21.8.jar (matches pingdisplay-1.0.0-mc1.21.4.jar naming used in the v1.0.0-mc1.21.4 release) - GitHub Release title prefixed with 'PingDisplay' to match 'PingDisplay v1.0.0 for MC 1.21.4' style
Parse mod version and MC version from the tag (format v<modVer>-mc<mcVer>) and use them to produce a release identical to the 1.21.4 one: Title: PingDisplay v1.0.0 for MC 1.21.8 Body: Initial release for Minecraft 1.21.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created by @kiro-agent on behalf of @Fix85 👻
Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro autonomous agent
Port the mod to Minecraft 1.21.8 and add a CI workflow that builds the JAR and publishes a GitHub Release on tag push.
Changes
gradle.properties: minecraft 1.21.4 -> 1.21.8, fabric API 0.119.4+1.21.4 -> 0.130.0+1.21.8, mod_version 1.0.0 -> 1.0.0-mc1.21.8 (matches naming of the v1.0.0-mc1.21.4 release)build.gradle: cloth-config-fabric 17.0.144 -> 19.0.147 (Fabric 1.21.6-8 build), modmenu 13.0.3 -> 15.0.0fabric.mod.json: minecraft dependency~1.21.4->~1.21.8README.md: version references updated.github/workflows/build.yml: new workflowmc-**branches and on PRs (uploads JAR as artifact)v<modVer>-mc<mcVer>publishes a Release with the JARPingDisplay v<modVer> for MC <mcVer>Initial release for Minecraft <mcVer>Tested
v1.0.0-mc1.21.8is now pushed to trigger the release.pingdisplay-1.0.0-mc1.21.8.jar(matchespingdisplay-1.0.0-mc1.21.4.jarfrom the existing 1.21.4 release).