Encapsulation #34
Merged
Encapsulation #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More encapsulation! Also replace direct "new NamespaceImpl()" calls with "Namespace.create()"
FixedDev
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NamespaceImplfinal and package-privateAnnotatedCommandTreeBuilderImplfinal and package-privateSimplePartInjectorfinal and package-privateAnotatedCommandBuilderImplfinal and package-privateCommandBuilderNodesImplfinal and package-privateI'm pretty sure
NamespaceImplshould be final and package-private, not sure about the others, but I can't see any usage for extending any of those classes, since none of them has any public method different from their implementing interface... well, maybe some class that changes the behavior of a single method? Even in that case, I think it should just use composition over inheritance.