Fix "idx" bug in split_data_by_length.py of BGE-M3#601
Merged
staoxiao merged 1 commit intoFlagOpen:masterfrom Mar 24, 2024
Merged
Fix "idx" bug in split_data_by_length.py of BGE-M3#601staoxiao merged 1 commit intoFlagOpen:masterfrom
staoxiao merged 1 commit intoFlagOpen:masterfrom
Conversation
Collaborator
|
Thanks! And we further fix the bug in #605 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the split_data_by_length.py code inside BGE-M3, after filtering the dataset by "max_length" field, the "idx" field is somehow changed , so the
split_dataset = dataset.select(idxs["idx"])will result in the wrong data.To deal with this issue, I suggest using the real list of "idx" given by
list(idxs._indices.to_pandas()['indices'].values).