Skip to content

Fix bugs in step0-generate_embedding.py #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staoxiao merged 1 commit into from
Apr 11, 2024
Merged

Fix bugs in step0-generate_embedding.py #675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions C_MTEB/MKQA/dense_retrieval/step0-generate_embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
--max_passage_length 512 \
--batch_size 256 \
--fp16 \
--add_instruction False \
--pooling_method cls \
--normalize_embeddings True
"""
Expand Down Expand Up @@ -35,14 +34,6 @@ class ModelArgs:
default=True,
metadata={'help': 'Use fp16 in inference?'}
)
add_instruction: bool = field(
default=False,
metadata={'help': 'Add instruction?'}
)
passage_instruction_for_retrieval: str = field(
default=None,
metadata={'help': 'passage instruction for retrieval'}
)
pooling_method: str = field(
default='cls',
metadata={'help': "Pooling method. Avaliable methods: 'cls', 'mean'"}
Expand Down Expand Up @@ -78,8 +69,6 @@ def get_model(model_args: ModelArgs):
model_args.encoder,
pooling_method=model_args.pooling_method,
normalize_embeddings=model_args.normalize_embeddings,
# query_instruction_for_retrieval=model_args.query_instruction_for_retrieval if model_args.add_instruction else None,
passage_instruction_for_retrieval=model_args.passage_instruction_for_retrieval if model_args.add_instruction else None,
use_fp16=model_args.fp16
)
return model
Expand Down
11 changes: 0 additions & 11 deletions C_MTEB/MLDR/dense_retrieval/step0-generate_embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
--max_passage_length 8192 \
--batch_size 4 \
--fp16 \
--add_instruction False \
--pooling_method cls \
--normalize_embeddings True
"""
Expand All @@ -30,14 +29,6 @@ class ModelArgs:
default=True,
metadata={'help': 'Use fp16 in inference?'}
)
add_instruction: bool = field(
default=False,
metadata={'help': 'Add instruction?'}
)
passage_instruction_for_retrieval: str = field(
default=None,
metadata={'help': 'passage instruction for retrieval'}
)
pooling_method: str = field(
default='cls',
metadata={'help': "Pooling method. Avaliable methods: 'cls', 'mean'"}
Expand Down Expand Up @@ -78,8 +69,6 @@ def get_model(model_args: ModelArgs):
model_args.encoder,
pooling_method=model_args.pooling_method,
normalize_embeddings=model_args.normalize_embeddings,
# query_instruction_for_retrieval=model_args.query_instruction_for_retrieval if model_args.add_instruction else None,
passage_instruction_for_retrieval=model_args.passage_instruction_for_retrieval if model_args.add_instruction else None,
use_fp16=model_args.fp16
)
return model
Expand Down