-
Notifications
You must be signed in to change notification settings - Fork 16
Realtime Updates Implementation #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Feature/real time flags
.github/workflows/publish_master.yml
Outdated
with: | ||
flutter-version: '2.x' | ||
channel: 'any' | ||
flutter-version: '3.10.6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we've pinned to this version? Can we do '3.x'
and stable
? Also, does this mean we're no longer supporting flutter 2.x
as part of this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah sure I can move to 3.x
.
I haven't done anything specifically to remove support of 2.x but I think people will struggle to get it running on 2.x without a lot of dependency overrides, just due to the dependencies we're now using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. You mean the dependencies we've added in this PR, or the ones we're already using?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly the upgrades that I've done in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I don't know the flutter/dart ecosystem well enough. Is this something that we should major version for or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a major version for this combined with the realtime updates would make sense and we can make a note of it in the release notes.
No description provided.