Skip to content

Conversation

jackforesightmobile
Copy link
Collaborator

No description provided.

with:
flutter-version: '2.x'
channel: 'any'
flutter-version: '3.10.6'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we've pinned to this version? Can we do '3.x' and stable ? Also, does this mean we're no longer supporting flutter 2.x as part of this work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sure I can move to 3.x.

I haven't done anything specifically to remove support of 2.x but I think people will struggle to get it running on 2.x without a lot of dependency overrides, just due to the dependencies we're now using.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. You mean the dependencies we've added in this PR, or the ones we're already using?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly the upgrades that I've done in this PR.

Copy link
Contributor

@matthewelwell matthewelwell Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I don't know the flutter/dart ecosystem well enough. Is this something that we should major version for or not?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a major version for this combined with the realtime updates would make sense and we can make a note of it in the release notes.

@matthewelwell matthewelwell merged commit ffc6502 into Flagsmith:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants